Skip to content
Extraits de code Groupes Projets
Non vérifiée Valider 64eea45a rédigé par Tadeusz Sośnierz's avatar Tadeusz Sośnierz Validation de GitHub
Parcourir les fichiers

Fix matrix metrics handling (#869)


* Fix matrix metrics handling

* Add changelog

Co-authored-by: default avatarTadeusz Sośnierz <tadeusz@sosnierz.com>
parent d582bc36
Aucune branche associée trouvée
Aucune étiquette associée trouvée
Aucune requête de fusion associée trouvée
Fix a crash caused by processing metrics for Matrix events.
\ No newline at end of file
...@@ -69,7 +69,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics { ...@@ -69,7 +69,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
private remoteRequest: Histogram<string>; private remoteRequest: Histogram<string>;
private matrixRequest: Histogram<string>; private matrixRequest: Histogram<string>;
private requestsInFlight: Map<string, number>; private requestsInFlight: Map<string, number>;
private matrixRequestStatus: Map<string, "success"|"failed">; private matrixRequestStatus: Map<string, "success"|"failed"> = new Map();
private httpServer: http.Server; private httpServer: http.Server;
private remoteMonthlyActiveUsers: Gauge<string>; private remoteMonthlyActiveUsers: Gauge<string>;
private bridgeBlocked: Gauge<string>; private bridgeBlocked: Gauge<string>;
...@@ -116,7 +116,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics { ...@@ -116,7 +116,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
this.matrixRequest = new Histogram({ this.matrixRequest = new Histogram({
help: "Histogram of processing durations of received Matrix messages", help: "Histogram of processing durations of received Matrix messages",
labelNames: ["outcome"], labelNames: ["outcome", "method"],
name: "matrix_request_seconds", name: "matrix_request_seconds",
}); });
register.registerMetric(this.matrixRequest); register.registerMetric(this.matrixRequest);
...@@ -208,7 +208,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics { ...@@ -208,7 +208,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
this.matrixRequestStatus.delete(context.uniqueId); this.matrixRequestStatus.delete(context.uniqueId);
this.matrixRequest.observe({ this.matrixRequest.observe({
method: context.functionName, method: context.functionName,
result: successFail, outcome: successFail,
}, timeMs); }, timeMs);
} }
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Terminez d'abord l'édition de ce message.
Veuillez vous inscrire ou vous pour commenter