Skip to content
Extraits de code Groupes Projets
Vérifiée Valider feb203a4 rédigé par Kubat's avatar Kubat
Parcourir les fichiers

Update comments in the vivy document view part to know why some things where done that way

parent 65911660
Aucune branche associée trouvée
Aucune étiquette associée trouvée
1 requête de fusion!15Video playback with mpv
......@@ -88,6 +88,9 @@ VivyDocumentView::loadVideoView() noexcept
addDockWidget(Qt::BottomDockWidgetArea, videoView, Qt::Vertical);
}
// Kubat: because the dock is "closable", when closed the widget itself
// is not deleted, it will be hidden and the content will be deleted.
// TODO: Check if it works on more platforms.
videoView->setWidget(new VideoView(videoView));
qobject_cast<VideoView *>(videoView->widget())
->loadFile(document->getVideoSubDocument()->getFilePath());
......@@ -136,12 +139,9 @@ VivyDocumentView::loadAudioView() noexcept
addDockWidget(Qt::LeftDockWidgetArea, visualizer, Qt::Horizontal);
}
// Kubat: don't check, may throw an error but don't think we can
// recover from it.
AudioVisualizer *visualizerInner = new AudioVisualizer(stream, visualizer);
if (visualizerInner == nullptr) {
qCritical() << "Failed to create visualizer for" << audioDocument->getFilePath();
return;
}
visualizer->setWidget(visualizerInner);
visualizer->layout()->setAlignment(visualizerInner, Qt::AlignTop);
}
......@@ -158,7 +158,7 @@ VivyDocumentView::closeDocument() noexcept
<< document.use_count() << ")";
vivyApp->documentStore.closeDocument(document->getUuid());
// The visualizer pointer should have been deleted by the
// Kubat: the visualizer pointer should have been deleted by the
// deleteAllContent() call if it was created.
deleteAllContent();
visualizer = nullptr;
......
0% Chargement en cours ou .
You are about to add 0 people to the discussion. Proceed with caution.
Veuillez vous inscrire ou vous pour commenter