From feb203a416a03d5973fafbbfe0e77f4495126bd5 Mon Sep 17 00:00:00 2001
From: Kubat <mael.martin31@gmail.com>
Date: Wed, 4 Aug 2021 11:51:08 +0200
Subject: [PATCH] Update comments in the vivy document view part to know why
 some things where done that way

---
 src/UI/VivyDocumentView.cc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/UI/VivyDocumentView.cc b/src/UI/VivyDocumentView.cc
index 4235dd50..05e840a6 100644
--- a/src/UI/VivyDocumentView.cc
+++ b/src/UI/VivyDocumentView.cc
@@ -88,6 +88,9 @@ VivyDocumentView::loadVideoView() noexcept
             addDockWidget(Qt::BottomDockWidgetArea, videoView, Qt::Vertical);
         }
 
+        // Kubat: because the dock is "closable", when closed the widget itself
+        // is not deleted, it will be hidden and the content will be deleted.
+        // TODO: Check if it works on more platforms.
         videoView->setWidget(new VideoView(videoView));
         qobject_cast<VideoView *>(videoView->widget())
             ->loadFile(document->getVideoSubDocument()->getFilePath());
@@ -136,12 +139,9 @@ VivyDocumentView::loadAudioView() noexcept
             addDockWidget(Qt::LeftDockWidgetArea, visualizer, Qt::Horizontal);
         }
 
+        // Kubat: don't check, may throw an error but don't think we can
+        // recover from it.
         AudioVisualizer *visualizerInner = new AudioVisualizer(stream, visualizer);
-        if (visualizerInner == nullptr) {
-            qCritical() << "Failed to create visualizer for" << audioDocument->getFilePath();
-            return;
-        }
-
         visualizer->setWidget(visualizerInner);
         visualizer->layout()->setAlignment(visualizerInner, Qt::AlignTop);
     }
@@ -158,7 +158,7 @@ VivyDocumentView::closeDocument() noexcept
              << document.use_count() << ")";
     vivyApp->documentStore.closeDocument(document->getUuid());
 
-    // The visualizer pointer should have been deleted by the
+    // Kubat: the visualizer pointer should have been deleted by the
     // deleteAllContent() call if it was created.
     deleteAllContent();
     visualizer = nullptr;
-- 
GitLab