Merge pull request #250 from Half-Shot/hs/allow-crap-image-events

Allow files missing `info`

src/matrixeventprocessor.ts

@@ -186,8 +186,9 @@ export class MatrixEventProcessor {
         }
 
         if (event.content.info == null) {
-            log.info("Event was an attachment type but was missing a content.info");
-            return "";
+            // Fractal sends images without an info, which is technically allowed
+            // but super unhelpful:  https://gitlab.gnome.org/World/fractal/issues/206
+            event.content.info = {size: 0};
         }
 
         if (event.content.url == null) {

test/test_matrixeventprocessor.ts

@@ -508,6 +508,7 @@ describe("MatrixEventProcessor", () => {
         });
     });
     describe("HandleAttachment", () => {
+        const SMALL_FILE = 200;
         it("message without an attachment", () => {
             const processor = createMatrixEventProcessor();
             return expect(processor.HandleAttachment({
@@ -521,8 +522,14 @@ describe("MatrixEventProcessor", () => {
             return expect(processor.HandleAttachment({
                 content: {
                     msgtype: "m.video",
+                    body: "filename.webm",
+                    url: "mxc://localhost/200",
                 },
-            }, mxClient)).to.eventually.eq("");
+            }, mxClient)).to.eventually.satisfy((attachment) => {
+                expect(attachment.name).to.eq("filename.webm");
+                expect(attachment.attachment.length).to.eq(SMALL_FILE);
+                return true;
+            });
         });
         it("message without a url", () => {
             const processor = createMatrixEventProcessor();
@@ -550,7 +557,6 @@ describe("MatrixEventProcessor", () => {
             }, mxClient)).to.eventually.eq("[filename.webm](https://localhost/8000000)");
         });
         it("message with a small info.size", () => {
-            const SMALL_FILE = 200;
             const processor = createMatrixEventProcessor();
             return expect(processor.HandleAttachment({
                 content: {