Check if a kara has mdt, correct value return for kara_metadata_write

src/mkv/write.c

@@ -108,8 +108,7 @@ kara_metadata_write(struct kara_metadata *mdt, const char *filename, const char
     char *const metadafilepath = &tmpfilepath[4];
     const char *const args1[] = { mkvpropedit, "-t", "all:", filename, NULL };
     const char *const args2[] = { mkvpropedit, "-t", tmpfilepath, filename, NULL };
-    int fd;
-    bool sta = false;
+    int fd, sta = -1;
 
     memset(tmpfilepath, 0, PATH_MAX);
     strncat(tmpfilepath, "all:/tmp/lektor.metadata.XXXXXX", PATH_MAX - 1);
@@ -128,7 +127,7 @@ kara_metadata_write(struct kara_metadata *mdt, const char *filename, const char
     if (!mkvpropedit__(args1) || !mkvpropedit__(args2))
         goto error;
 
-    sta = true;
+    sta = 0;
 error:
     close(fd);
     unlink(metadafilepath);
@@ -207,7 +206,7 @@ metadata_set_directory(const char *kara_dir, const char *mkvpropedit)
 
         if (dir->d_type == DT_REG               &&
             metadata_from_path(path, &meta)     &&
-            kara_metadata_write(&meta, path, mkvpropedit))
+            ! kara_metadata_write(&meta, path, mkvpropedit))
             continue;
         else if (dir->d_type == DT_DIR          &&
                  !STR_MATCH(dir->d_name, ".")   &&
@@ -226,6 +225,6 @@ metadata_set_file(char *karapath, const char *mkvpropedit)
     struct kara_metadata meta;
 
     return metadata_from_path(karapath, &meta) &&
-           kara_metadata_write(&meta, karapath, mkvpropedit);
+           ! kara_metadata_write(&meta, karapath, mkvpropedit);
 }
 

src/net/downloader.c

@@ -381,7 +381,7 @@ __handle_got_json(volatile sqlite3 *db, struct lkt_repo *repo, struct json_objec
             continue;
         }
 
-        if (!kara_metadata_write(&kara.mdt, kara.filename, mkvpropedit)) {
+        if (kara_metadata_write(&kara.mdt, kara.filename, mkvpropedit)) {
             LOG_WARN_SCT("REPO", "Could not write metadata to kara '%ld' with path '%s'", kara.id, kara.filename);
             continue;
         }