MISC: Move document type enums in the same header file

src/Document/CRTPSubDocument.hh

@@ -11,25 +11,8 @@
 #include <QString>
 #include <memory>
 
-// Types for the different documents
-
 namespace Vivy
 {
-enum class AudioDocumentType : quint64 {
-    MP3 = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::MP3),
-    OGG = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::OGG),
-    M4A = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::M4A),
-};
-
-enum class VideoDocumentType : quint64 {
-    MKV = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::MKV),
-    MP4 = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::MP4),
-};
-
-enum class AssDocumentType : quint64 {
-    ASS = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::ASS),
-};
-
 // The Big CRTP class for all common things to all the subdocuments
 template <class CRTPSubDocumentType, class Document> class CRTPSubDocument {
 public:
@@ -114,7 +97,7 @@ private:
 class AssSubDocument final : public CRTPSubDocument<AssDocumentType, AssSubDocument> {
     const QStringList &suffixList = Vivy::Utils::assFileSuffix;
 
-    inline void initFromPath([[maybe_unused]] const QString &path)
+    inline void initFromPath(const QString &path)
     {
         Ass::AssFactory factory(path);
         factory.getStyles(styles);

src/Lib/Utils.hh

@@ -69,7 +69,26 @@ to_underlying(E e) noexcept
 bool detectDocumentType(const QFileInfo &, DocumentType *);
 }
 
-/* All forward delcarations are placed here */
+namespace Vivy
+{
+// Audio document types
+enum class AudioDocumentType : quint64 {
+    MP3 = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::MP3),
+    OGG = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::OGG),
+    M4A = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::M4A),
+};
+
+// Video document types
+enum class VideoDocumentType : quint64 {
+    MKV = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::MKV),
+    MP4 = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::MP4),
+};
+
+// Ass document types
+enum class AssDocumentType : quint64 {
+    ASS = Vivy::Utils::to_underlying(Vivy::Utils::DocumentType::ASS),
+};
+}
 
 class QMenu;
 class QAction;