MISC: The getCurrentDocument and getCurrentDocumentView now throw errors...

MISC: The getCurrentDocument and getCurrentDocumentView now throw errors instead of returning nullptr => uniform API

src/UI/MainWindow.cc

@@ -211,24 +211,18 @@ MainWindow::openDialogHelp() noexcept
 }
 
 AbstractDocument *
-MainWindow::getCurrentDocument() const noexcept
+MainWindow::getCurrentDocument() const
 {
-    try {
     return getCurrentDocumentView()->getDocument();
-    } catch (const std::runtime_error &e) {
-        qCritical() << "No current view in the main window:" << e.what();
-        return nullptr;
-    }
 }
 
 void
 MainWindow::saveFile() noexcept
 {
     try {
-        if (auto document = getCurrentDocument()) {
+        auto document = getCurrentDocument();
         qDebug() << "Request to save the document" << document->getName();
         document->save();
-        }
     } catch (const std::runtime_error &e) {
         qCritical() << "Failed to save current document:" << e.what();
     }
@@ -238,7 +232,7 @@ void
 MainWindow::saveFileAs() noexcept
 {
     try {
-        if (auto document = getCurrentDocument()) {
+        auto document = getCurrentDocument();
         qDebug() << "Request to save the document" << document->getName();
         const QString filename =
             dialogSaveFileName("Select the target file to save into", QDir::homePath(),
@@ -249,7 +243,6 @@ MainWindow::saveFileAs() noexcept
             document->rename(filename);
             document->save();
         }
-        }
     } catch (const std::runtime_error &e) {
         qCritical() << "Failed to save current document:" << e.what();
     }

src/UI/MainWindow.hh

@@ -29,14 +29,14 @@ class MainWindow final : public QMainWindow {
 public:
     explicit MainWindow() noexcept;
 
-    AbstractDocument *getCurrentDocument() const noexcept;
-    template <class Document> Document *getCurrentDocument() const noexcept
+    AbstractDocument *getCurrentDocument() const;
+    template <class Document> Document *getCurrentDocument() const
     {
         if (AbstractDocumentView *currentView = getCurrentDocumentView();
             currentView->getType() == Document::type) {
             return currentView->getDocument();
         } else {
-            return nullptr;
+            throw std::runtime_error("No main document view was found");
         }
     }
 

src/UI/VivyDocumentView.cc

@@ -74,6 +74,9 @@ VivyDocumentView::getDocumentTabToolTip() const noexcept
            QStringLiteral("}") +
            (document->checkDocumentOption(VivyDocument::UntouchedByDefault)
                 ? QStringLiteral("\nUntouched document")
+                : QStringLiteral("")) +
+           (document->checkDocumentOption(VivyDocument::MemoryDocumentCreation)
+                ? QStringLiteral("\nMemory document")
                 : QStringLiteral(""));
 }