From 856c27b4dec88d7472c7d23d8d374d61870a6fe0 Mon Sep 17 00:00:00 2001
From: Kubat <mael.martin31@gmail.com>
Date: Fri, 29 Oct 2021 17:35:58 +0200
Subject: [PATCH] BUILD: Fix gcc's warnings

---
 CMakeLists.txt           |  3 +-
 inc/lektor/queue.h       |  4 ---
 src/base/bufferfd.c      |  2 --
 src/base/cmd.c           |  2 --
 src/base/commands.c      | 20 +++++------
 src/base/common.c        |  2 --
 src/base/config.c        |  2 --
 src/base/json.c          |  2 --
 src/base/launch.c        |  1 -
 src/base/logfile.c       |  2 --
 src/base/os.c            |  2 --
 src/base/reg.c           |  2 --
 src/base/segv.c          |  2 --
 src/base/stack.c         |  2 --
 src/base/uri.c           |  2 --
 src/database/cache.c     |  2 --
 src/database/config.c    |  2 --
 src/database/find.c      | 14 ++++----
 src/database/open.c      |  2 --
 src/database/playlist.c  |  2 --
 src/database/queue.c     |  4 +--
 src/database/stickers.c  |  2 --
 src/database/update.c    |  1 -
 src/database/user.c      |  2 --
 src/main/lkt.c           |  2 --
 src/main/luka.c          |  2 --
 src/main/server.c        |  2 --
 src/mkv/mkv.c            |  4 +--
 src/mkv/utils.c          |  2 --
 src/mkv/write.c          | 78 ++++++++++++++++++++--------------------
 src/module/module_repo.c | 12 +++----
 src/module/module_sdl2.c |  2 --
 src/module/mpv.c         |  2 --
 src/module/thread.h      | 13 ++++---
 src/module/worker.c      |  2 --
 src/net/command.c        |  2 --
 src/net/listen.c         |  2 --
 src/net/message.c        |  2 --
 38 files changed, 70 insertions(+), 138 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index db413d80..8aca2dce 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -12,7 +12,7 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(THREADS_PREFER_PTHREAD_FLAG     ON)
 
 set(COMMON_C_FLAGS
-    -Wall -Wextra -Wpedantic -Werror
+    -Wall -Wextra -Werror
     -Wshadow
     -Wcast-align
     -Wconversion
@@ -29,6 +29,7 @@ set(COMMON_C_FLAGS
 
 set(clang_C_FLAGS
     -Weverything
+    -Wpedantic
     -Wno-extra-semi-stmt
     -Wno-reserved-id-macro
     -Wno-reserved-identifier
diff --git a/inc/lektor/queue.h b/inc/lektor/queue.h
index 2bd52eab..508cdb99 100644
--- a/inc/lektor/queue.h
+++ b/inc/lektor/queue.h
@@ -5,10 +5,6 @@
 extern "C" {
 #endif
 
-#if !defined(_POSIX_C_SOURCE)
-#define _POSIX_C_SOURCE 200809L
-#endif
-
 /* Everything in this file is implemented in the header, so that modules don't
    have to compile the lib with another .c file. */
 
diff --git a/src/base/bufferfd.c b/src/base/bufferfd.c
index 17d60467..6def50af 100644
--- a/src/base/bufferfd.c
+++ b/src/base/bufferfd.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/bufferfd.h>
 
diff --git a/src/base/cmd.c b/src/base/cmd.c
index f0799c50..711ddedb 100644
--- a/src/base/cmd.c
+++ b/src/base/cmd.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/cmd.h>
 #include <wait.h>
diff --git a/src/base/commands.c b/src/base/commands.c
index 8fd7fa22..52598757 100644
--- a/src/base/commands.c
+++ b/src/base/commands.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/commands.h>
 #include <lektor/database.h>
@@ -747,7 +745,7 @@ command_set_playback_option(struct lkt_state *srv, size_t UNUSED c, LKT_PLAYBACK
     RETURN_UNLESS(srv, "Invalid argument", false);
     long val;
     char *endptr = NULL;
-    char ret     = false;
+    bool ret     = false;
 
     if (args == NULL || args[0] == NULL)
         val = 0;
@@ -1061,10 +1059,10 @@ command_user_add(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MA
 /* Stickers */
 
 // clang-format off
-PRIVATE_FUNCTION bool command_sticker_create(struct lkt_state *, size_t, char *[LKT_MESSAGE_ARGS_MAX]);
-PRIVATE_FUNCTION bool command_sticker_get   (struct lkt_state *, size_t, char *[LKT_MESSAGE_ARGS_MAX]);
-PRIVATE_FUNCTION bool command_sticker_set   (struct lkt_state *, size_t, char *[LKT_MESSAGE_ARGS_MAX]);
-PRIVATE_FUNCTION bool command_sticker_delete(struct lkt_state *, size_t, char *[LKT_MESSAGE_ARGS_MAX]);
+PRIVATE_FUNCTION bool command_sticker_create(struct lkt_state *, size_t, char *[LKT_MESSAGE_ARGS_MAX - 1]);
+PRIVATE_FUNCTION bool command_sticker_get   (struct lkt_state *, size_t, char *[LKT_MESSAGE_ARGS_MAX - 1]);
+PRIVATE_FUNCTION bool command_sticker_set   (struct lkt_state *, size_t, char *[LKT_MESSAGE_ARGS_MAX - 1]);
+PRIVATE_FUNCTION bool command_sticker_delete(struct lkt_state *, size_t, char *[LKT_MESSAGE_ARGS_MAX - 1]);
 // clang-format on
 
 PRIVATE_FUNCTION bool
@@ -1099,7 +1097,7 @@ command_sticker_handle(struct lkt_state *srv, size_t c, char *args[LKT_MESSAGE_A
 }
 
 PRIVATE_FUNCTION bool
-command_sticker_create(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MAX])
+command_sticker_create(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MAX - 1])
 {
     LOG_INFO("COMMAND", "Client %ld is using the sticker create command", c);
     RETURN_UNLESS(argv[0], "Invalid argument", false);
@@ -1112,7 +1110,7 @@ command_sticker_create(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_A
 }
 
 PRIVATE_FUNCTION bool
-command_sticker_set(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MAX])
+command_sticker_set(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MAX - 1])
 {
     RETURN_UNLESS(argv[0] && argv[1] && argv[2] && argv[3] && !argv[4], "Invalid argument", false);
     long uri, value;
@@ -1128,7 +1126,7 @@ command_sticker_set(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS
 }
 
 PRIVATE_FUNCTION bool
-command_sticker_get(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MAX])
+command_sticker_get(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MAX - 1])
 {
     LOG_INFO("COMMAND", "Client %ld is using the sticker get command", c);
     struct lkt_sticker_opt stkr = LKT_STICKER_OPT_INIT;
@@ -1184,7 +1182,7 @@ unknown:
 }
 
 PRIVATE_FUNCTION bool
-command_sticker_delete(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MAX])
+command_sticker_delete(struct lkt_state *srv, size_t c, char *argv[LKT_MESSAGE_ARGS_MAX - 1])
 {
     LOG_INFO("COMMAND", "Client %ld is using the sticker delete command", c);
     RETURN_UNLESS(argv[0] && argv[1] && argv[2], "Invalid argument", false);
diff --git a/src/base/common.c b/src/base/common.c
index e781aa57..b5cae9f7 100644
--- a/src/base/common.c
+++ b/src/base/common.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/logfile.h>
 
diff --git a/src/base/config.c b/src/base/config.c
index 7e51e676..41d567be 100644
--- a/src/base/config.c
+++ b/src/base/config.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/config.h>
 #include <lektor/database.h>
diff --git a/src/base/json.c b/src/base/json.c
index 4a16254e..166404fb 100644
--- a/src/base/json.c
+++ b/src/base/json.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/json.h>
 
diff --git a/src/base/launch.c b/src/base/launch.c
index dd34c736..984bc870 100644
--- a/src/base/launch.c
+++ b/src/base/launch.c
@@ -1,6 +1,5 @@
 /* Contains all the functions that can be called at launch time with the hook
  * in the config file and the resulv functions. */
-#define _POSIX_C_SOURCE 200809L
 
 #include <lektor/common.h>
 #include <lektor/database.h>
diff --git a/src/base/logfile.c b/src/base/logfile.c
index d9a621ef..18755adc 100644
--- a/src/base/logfile.c
+++ b/src/base/logfile.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/logfile.h>
 
 struct lkt_logfile {
diff --git a/src/base/os.c b/src/base/os.c
index 933721a3..a18c9bad 100644
--- a/src/base/os.c
+++ b/src/base/os.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 
 #if defined(__linux__)
diff --git a/src/base/reg.c b/src/base/reg.c
index 8ef53fd0..7ccdccbf 100644
--- a/src/base/reg.c
+++ b/src/base/reg.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/reg.h>
 #include <lektor/database.h>
diff --git a/src/base/segv.c b/src/base/segv.c
index 0c1ad1d7..f6127829 100644
--- a/src/base/segv.c
+++ b/src/base/segv.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 /* Try to print the backtrace when a segfault occures if possible */
 
 #include <lektor/common.h>
diff --git a/src/base/stack.c b/src/base/stack.c
index 6071f079..f2e7fc0b 100644
--- a/src/base/stack.c
+++ b/src/base/stack.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/stack.h>
 #include <lektor/common.h>
 
diff --git a/src/base/uri.c b/src/base/uri.c
index 2876834d..2e1ac079 100644
--- a/src/base/uri.c
+++ b/src/base/uri.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/uri.h>
 
diff --git a/src/database/cache.c b/src/database/cache.c
index f35453f0..d3d84e18 100644
--- a/src/database/cache.c
+++ b/src/database/cache.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/database.h>
 #include <lektor/internal/dbmacro.h>
diff --git a/src/database/config.c b/src/database/config.c
index ba2a56b7..c9befe26 100644
--- a/src/database/config.c
+++ b/src/database/config.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/database.h>
 #include <lektor/internal/dbmacro.h>
diff --git a/src/database/find.c b/src/database/find.c
index 75be6f60..64b81e0b 100644
--- a/src/database/find.c
+++ b/src/database/find.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/database.h>
 #include <lektor/net.h>
@@ -255,17 +253,19 @@ database_search_sticker_init(lkt_db *db, struct lkt_search *ret)
                                        "  SELECT id, sticker, value , 'plt' FROM 'stickers.plt'"
                                        ") AS sts"
                                        "ON sts.sticker = 'stickers'.id";
-    static const char *SQL_one_type  = "SELECT name, sts.id, value, '%s' "
-                                       "FROM 'stickers.%s' AS sts "
-                                       "JOIN 'stickers' "
-                                       "ON 'stickers'.id = sts.sticker";
+
     char SQL[LKT_MAX_SQLITE_STATEMENT];
     ret->type = lkt_search_sticker;
 
     if (ret->st.type == NULL)
         memcpy(SQL, SQL_all_types, strlen(SQL_all_types) + 1);
     else
-        sprintf(SQL, SQL_one_type, ret->st.type, ret->st.type);
+        sprintf(SQL,
+                "SELECT name, sts.id, value, '%s' "
+                "FROM 'stickers.%s' AS sts "
+                "JOIN 'stickers' "
+                "ON 'stickers'.id = sts.sticker",
+                ret->st.type, ret->st.type);
     if (ret->st.uri != 0)
         sprintf(SQL + strlen(SQL), " AND sts.id = %d", ret->st.uri);
     if (ret->st.op != 0)
diff --git a/src/database/open.c b/src/database/open.c
index 41058fd1..9770786e 100644
--- a/src/database/open.c
+++ b/src/database/open.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/stack.h>
 #include <lektor/database.h>
diff --git a/src/database/playlist.c b/src/database/playlist.c
index 7d2d5d17..efb3cdf3 100644
--- a/src/database/playlist.c
+++ b/src/database/playlist.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/database.h>
 #include <lektor/internal/dbmacro.h>
diff --git a/src/database/queue.c b/src/database/queue.c
index aec4698d..69f4997e 100644
--- a/src/database/queue.c
+++ b/src/database/queue.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/database.h>
 #include <lektor/internal/dbmacro.h>
@@ -334,6 +332,8 @@ database_queue_add_uri(lkt_db *db, struct lkt_uri *uri, int prio)
         LOG_WARN("DB", "Add to queue for uri of type %d is not implemented", uri->type);
         return false;
     }
+
+    LOG_UNREACHABLE;
 }
 
 bool
diff --git a/src/database/stickers.c b/src/database/stickers.c
index 3271a218..3a35e784 100644
--- a/src/database/stickers.c
+++ b/src/database/stickers.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/database.h>
 #include <lektor/internal/dbmacro.h>
diff --git a/src/database/update.c b/src/database/update.c
index 8a556ee1..a441318d 100644
--- a/src/database/update.c
+++ b/src/database/update.c
@@ -1,4 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
 #define _DEFAULT_SOURCE
 
 #include <lektor/common.h>
diff --git a/src/database/user.c b/src/database/user.c
index c6fcfb86..d18d8f9d 100644
--- a/src/database/user.c
+++ b/src/database/user.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/database.h>
 #include <lektor/internal/dbmacro.h>
diff --git a/src/main/lkt.c b/src/main/lkt.c
index 6eafa022..d76b25cb 100644
--- a/src/main/lkt.c
+++ b/src/main/lkt.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/net.h>
 #include <lektor/cmd.h>
diff --git a/src/main/luka.c b/src/main/luka.c
index 487c22ae..f0fbd5df 100644
--- a/src/main/luka.c
+++ b/src/main/luka.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/cmd.h>
 #include <lektor/config.h>
diff --git a/src/main/server.c b/src/main/server.c
index 2c756ce6..3942ff15 100644
--- a/src/main/server.c
+++ b/src/main/server.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200808L
-
 #include <lektor/common.h>
 #include <lektor/config.h>
 #include <lektor/net.h>
diff --git a/src/mkv/mkv.c b/src/mkv/mkv.c
index f95ea53a..9fea2290 100644
--- a/src/mkv/mkv.c
+++ b/src/mkv/mkv.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/bufferfd.h>
 #include <lektor/mkv.h>
 #include <lektor/common.h>
@@ -410,7 +408,7 @@ mkv_read_tag(struct bufferfd *bf, struct mkv_tag *res)
     if ((consumed = mkv_read_element_length(bf, &data_len)) < 0)
         return -1;
 
-    consumed += data_len;
+    consumed += (ssize_t)data_len;
 
     for (size_t i = 0; i < MKV_TAG_MAX && data_len > 0;) {
         uint32_t eid;
diff --git a/src/mkv/utils.c b/src/mkv/utils.c
index b5a48feb..3fe5bce9 100644
--- a/src/mkv/utils.c
+++ b/src/mkv/utils.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/mkv.h>
 
diff --git a/src/mkv/write.c b/src/mkv/write.c
index 7e975a66..b5ca847f 100644
--- a/src/mkv/write.c
+++ b/src/mkv/write.c
@@ -1,4 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
 #define _DEFAULT_SOURCE
 
 #include <lektor/common.h>
@@ -6,44 +5,45 @@
 #include <dirent.h>
 #include <sys/wait.h>
 
-static const char *METADATA_TEMPLATE = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
-                                       "<Tags>                                    "
-                                       "<Tag>                                     "
-                                       "  <Targets>                               "
-                                       "    <TargetTypeValue>70</TargetTypeValue> "
-                                       "  </Targets>                              "
-                                       "  <Simple>                                "
-                                       "    <Name>TITLE</Name>                    "
-                                       "    <String>%s</String>                   "
-                                       "  </Simple>                               "
-                                       "</Tag>                                    "
-                                       "<Tag>                                     "
-                                       "  <Simple>                                "
-                                       "    <Name>TITLE</Name>                    "
-                                       "    <String>%s</String>                   "
-                                       "  </Simple>                               "
-                                       "  <Simple>                                "
-                                       "    <Name>CONTENT_TYPE</Name>             "
-                                       "    <String>%s</String>                   "
-                                       "  </Simple>                               "
-                                       "  <Simple>                                "
-                                       "    <Name>ADDRESS</Name>                  "
-                                       "    <String>%s</String>                   "
-                                       "  </Simple>                               "
-                                       "  <Simple>                                "
-                                       "    <Name>ARTIST</Name>                   "
-                                       "    <String>%s</String>                   "
-                                       "  </Simple>                               "
-                                       "  <Simple>                                "
-                                       "    <Name>GENRE</Name>                    "
-                                       "    <String>%s</String>                   "
-                                       "  </Simple>                               "
-                                       "  <Simple>                                "
-                                       "    <Name>TRACK</Name>                    "
-                                       "    <String>%d</String>                   "
-                                       "  </Simple>                               "
-                                       "</Tag>                                    "
-                                       "</Tags>                                   ";
+#define METADATA_TEMPLATE                        \
+    "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" \
+    "<Tags>                                    " \
+    "<Tag>                                     " \
+    "  <Targets>                               " \
+    "    <TargetTypeValue>70</TargetTypeValue> " \
+    "  </Targets>                              " \
+    "  <Simple>                                " \
+    "    <Name>TITLE</Name>                    " \
+    "    <String>%s</String>                   " \
+    "  </Simple>                               " \
+    "</Tag>                                    " \
+    "<Tag>                                     " \
+    "  <Simple>                                " \
+    "    <Name>TITLE</Name>                    " \
+    "    <String>%s</String>                   " \
+    "  </Simple>                               " \
+    "  <Simple>                                " \
+    "    <Name>CONTENT_TYPE</Name>             " \
+    "    <String>%s</String>                   " \
+    "  </Simple>                               " \
+    "  <Simple>                                " \
+    "    <Name>ADDRESS</Name>                  " \
+    "    <String>%s</String>                   " \
+    "  </Simple>                               " \
+    "  <Simple>                                " \
+    "    <Name>ARTIST</Name>                   " \
+    "    <String>%s</String>                   " \
+    "  </Simple>                               " \
+    "  <Simple>                                " \
+    "    <Name>GENRE</Name>                    " \
+    "    <String>%s</String>                   " \
+    "  </Simple>                               " \
+    "  <Simple>                                " \
+    "    <Name>TRACK</Name>                    " \
+    "    <String>%d</String>                   " \
+    "  </Simple>                               " \
+    "</Tag>                                    " \
+    "</Tags>                                   "
 
 static bool
 mkvpropedit__(const char *const args[])
diff --git a/src/module/module_repo.c b/src/module/module_repo.c
index 7f1e9203..6edeef7d 100644
--- a/src/module/module_repo.c
+++ b/src/module/module_repo.c
@@ -1,14 +1,12 @@
-#define _POSIX_C_SOURCE 200809L
-
 #define __LKT_MODULE_MAIN_SOURCE__
 #include <lektor/lktmodule.h>
 
 #include "worker.h"
 
 /* Different kinds of updates */
-#define REPO_UPDATE_KARA       (1 << 1) /* Downloading or rescanning the bakabase */
-#define REPO_UPDATE_FAV        (1 << 2) /* Downloading the favorites */
-#define REPO_UPDATE_TYPE_COUNT 2        /* Different kinds of download, for some sizes... */
+#define REPO_UPDATE_TYPE_COUNT 2 /* Different kinds of download, for some sizes... */
+#define REPO_UPDATE_KARA       ((unsigned int)(1 << 1)) /* Downloading or rescanning the bakabase */
+#define REPO_UPDATE_FAV        ((unsigned int)(1 << 2)) /* Downloading the favorites */
 
 /***********
  * Globals *
@@ -63,9 +61,7 @@ struct module_repo_internal {
     void (*craft_filename)(char str[PATH_MAX], struct kara *);
 
     /* Worker threads */
-    // *INDENT-OFF*
-    volatile unsigned int updating : REPO_UPDATE_TYPE_COUNT; /* The correct size */
-    // *INDENT-ON*
+    volatile unsigned int updating;
     pthread_mutex_t mtx; /* Protect the updating field */
     struct worker_pool workers;
 };
diff --git a/src/module/module_sdl2.c b/src/module/module_sdl2.c
index 71d88887..530319af 100644
--- a/src/module/module_sdl2.c
+++ b/src/module/module_sdl2.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #define __LKT_MODULE_MAIN_SOURCE__
 #include <lektor/lktmodule.h>
 
diff --git a/src/module/mpv.c b/src/module/mpv.c
index caf6827f..8dc18582 100644
--- a/src/module/mpv.c
+++ b/src/module/mpv.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include "mpv.h"
 
 #include <lektor/common.h>
diff --git a/src/module/thread.h b/src/module/thread.h
index 109a3a94..ab011fbe 100644
--- a/src/module/thread.h
+++ b/src/module/thread.h
@@ -1,6 +1,5 @@
 #if !defined(__LKT_THREAD_H__)
 #define __LKT_THREAD_H__
-#define _POSIX_C_SOURCE 200809L
 
 #include <lektor/lktmodule.h>
 #include <lektor/common.h>
@@ -117,12 +116,12 @@ th_head(struct stack *lst, pthread_mutex_t *lock, void **ptr)
         return th_##operation(&th->inout, &th->inout##_lock, ptr);                        \
     }
 // clang-format off
-__POLLER_ATOMICS_DEFINE(append, input,  *);
-__POLLER_ATOMICS_DEFINE(append, output, *);
-__POLLER_ATOMICS_DEFINE(pop,    input,  **);
-__POLLER_ATOMICS_DEFINE(pop,    output, **);
-__POLLER_ATOMICS_DEFINE(head,   input,  **);
-__POLLER_ATOMICS_DEFINE(head,   output, **);
+__POLLER_ATOMICS_DEFINE(append, input,  *)
+__POLLER_ATOMICS_DEFINE(append, output, *)
+__POLLER_ATOMICS_DEFINE(pop,    input,  **)
+__POLLER_ATOMICS_DEFINE(pop,    output, **)
+__POLLER_ATOMICS_DEFINE(head,   input,  **)
+__POLLER_ATOMICS_DEFINE(head,   output, **)
 // clang-format on
 #undef __POLLER_ATOMICS_DEFINE
 
diff --git a/src/module/worker.c b/src/module/worker.c
index 562feb03..479d8f04 100644
--- a/src/module/worker.c
+++ b/src/module/worker.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include "worker.h"
 #include <lektor/common.h>
 #include <sys/sysinfo.h>
diff --git a/src/net/command.c b/src/net/command.c
index d216ec5e..78a69982 100644
--- a/src/net/command.c
+++ b/src/net/command.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/net.h>
 
diff --git a/src/net/listen.c b/src/net/listen.c
index 81d538f7..b7c4304f 100644
--- a/src/net/listen.c
+++ b/src/net/listen.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/common.h>
 #include <lektor/queue.h>
 #include <lektor/commands.h>
diff --git a/src/net/message.c b/src/net/message.c
index f752fcce..765f6fd8 100644
--- a/src/net/message.c
+++ b/src/net/message.c
@@ -1,5 +1,3 @@
-#define _POSIX_C_SOURCE 200809L
-
 #include <lektor/net.h>
 
 /* Private definition of the lkt_message struct */
-- 
GitLab