From f8afa95220670f70739ac17be9315c5ffa3a959c Mon Sep 17 00:00:00 2001
From: Elliu <elliu@hashi.re>
Date: Fri, 1 Sep 2023 19:27:20 +0200
Subject: [PATCH] COMPIL: fix misc. warnings
---
CMakeLists.txt | 5 ++++-
src/UI/DocumentViews/AudioVisualizer/TimingSeparator.cc | 4 ++--
src/UI/DocumentViews/AudioVisualizer/TimingSeparator.hh | 4 ++--
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 6a24b800..4cf8b3b3 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -100,7 +100,6 @@ target_compile_options(Vivy PRIVATE
-Wcast-align
-Wconversion
-Wsign-conversion
- -Wunused-variable
-Wmisleading-indentation
-Wnull-dereference
-Wdouble-promotion
@@ -108,6 +107,10 @@ target_compile_options(Vivy PRIVATE
-Woverloaded-virtual
-Wnon-virtual-dtor
-Wignored-qualifiers
+
+ # FIXME: temporary, for devel
+ -Wno-unused-variable
+ -Wno-unused-parameter
)
# Prepare for Qt6
diff --git a/src/UI/DocumentViews/AudioVisualizer/TimingSeparator.cc b/src/UI/DocumentViews/AudioVisualizer/TimingSeparator.cc
index 0d7f2682..82e48367 100644
--- a/src/UI/DocumentViews/AudioVisualizer/TimingSeparator.cc
+++ b/src/UI/DocumentViews/AudioVisualizer/TimingSeparator.cc
@@ -83,7 +83,7 @@ TimingSeparator::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
}
void
-TimingSeparator::silentlySetPos(int x, int y)
+TimingSeparator::silentlySetPos(qreal x, qreal y)
{
inhibMove = true;
setPos(x, y);
@@ -91,7 +91,7 @@ TimingSeparator::silentlySetPos(int x, int y)
}
void
-TimingSeparator::silentlyMoveBy(int x, int y)
+TimingSeparator::silentlyMoveBy(qreal x, qreal y)
{
inhibMove = true;
moveBy(x, y);
diff --git a/src/UI/DocumentViews/AudioVisualizer/TimingSeparator.hh b/src/UI/DocumentViews/AudioVisualizer/TimingSeparator.hh
index 0d85bdc1..498cafd8 100644
--- a/src/UI/DocumentViews/AudioVisualizer/TimingSeparator.hh
+++ b/src/UI/DocumentViews/AudioVisualizer/TimingSeparator.hh
@@ -37,8 +37,8 @@ protected:
void mouseReleaseEvent(QGraphicsSceneMouseEvent *event);
public:
- void silentlySetPos(int, int);
- void silentlyMoveBy(int, int);
+ void silentlySetPos(qreal, qreal);
+ void silentlyMoveBy(qreal, qreal);
};
}
--
GitLab