From f12b64d61489f9e1e7ff8ef4234ab011ae4a7dae Mon Sep 17 00:00:00 2001 From: Kubat <mael.martin31@gmail.com> Date: Mon, 21 Jun 2021 09:50:17 +0200 Subject: [PATCH] MISC: Mark most of the functions as noexcept --- src/AudioVisualizer.cc | 4 ++-- src/AudioVisualizer.h | 6 +++--- src/Main.cc | 2 +- src/MainWindow.cc | 4 ++-- src/MainWindow.h | 6 +++--- src/Timer.cc | 4 ++-- src/Timer.h | 6 +++--- src/TimingBar.cc | 4 ++-- src/TimingBar.h | 6 +++--- 9 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/AudioVisualizer.cc b/src/AudioVisualizer.cc index a882eb27..3e820031 100644 --- a/src/AudioVisualizer.cc +++ b/src/AudioVisualizer.cc @@ -8,13 +8,13 @@ #include <QMessageBox> #include <QGraphicsPixmapItem> -AudioVisualizer::AudioVisualizer(QWidget *parent) +AudioVisualizer::AudioVisualizer(QWidget *parent) noexcept : QWidget(parent) { } void -AudioVisualizer::printSpectrum(QImage pixmap) +AudioVisualizer::printSpectrum(QImage pixmap) noexcept { Timer *timer = new Timer(pixmap); QVBoxLayout *layout = new QVBoxLayout; diff --git a/src/AudioVisualizer.h b/src/AudioVisualizer.h index d62c46b0..ef363395 100644 --- a/src/AudioVisualizer.h +++ b/src/AudioVisualizer.h @@ -8,11 +8,11 @@ class AudioVisualizer final : public QWidget { Q_OBJECT public: - AudioVisualizer(QWidget *parent = nullptr); - ~AudioVisualizer() = default; + AudioVisualizer(QWidget *parent = nullptr) noexcept; + ~AudioVisualizer() noexcept = default; public slots: - void printSpectrum(QImage); + void printSpectrum(QImage) noexcept; }; #endif // VIVY_AUDIOVISUALIZER_H diff --git a/src/Main.cc b/src/Main.cc index 92644d33..c080b83f 100644 --- a/src/Main.cc +++ b/src/Main.cc @@ -2,7 +2,7 @@ #include <QApplication> int -main(int argc, char **argv) +main(int argc, char **argv) noexcept { QApplication app(argc, argv); MainWindow window; diff --git a/src/MainWindow.cc b/src/MainWindow.cc index 48174bad..82bd9e54 100644 --- a/src/MainWindow.cc +++ b/src/MainWindow.cc @@ -13,7 +13,7 @@ #include <QMenuBar> #include <QImage> -MainWindow::MainWindow(QWidget *parent) +MainWindow::MainWindow(QWidget *parent) noexcept : QMainWindow(parent) { openAudioFileAct = new QAction(tr("&Open audio"), this); @@ -32,7 +32,7 @@ MainWindow::MainWindow(QWidget *parent) } void -MainWindow::openAudioFile() +MainWindow::openAudioFile() noexcept { QString filename = QFileDialog::getOpenFileName(this, "Select a file"); if (filename.isEmpty()) diff --git a/src/MainWindow.h b/src/MainWindow.h index 1f95be88..fa23229b 100644 --- a/src/MainWindow.h +++ b/src/MainWindow.h @@ -11,11 +11,11 @@ class MainWindow final : public QMainWindow { Q_OBJECT public: - MainWindow(QWidget *parent = nullptr); - ~MainWindow() = default; + MainWindow(QWidget *parent = nullptr) noexcept; + ~MainWindow() noexcept = default; private slots: - void openAudioFile(); + void openAudioFile() noexcept; private: QMenu *fileMenu = nullptr; diff --git a/src/Timer.cc b/src/Timer.cc index a66eae87..0015b078 100644 --- a/src/Timer.cc +++ b/src/Timer.cc @@ -13,7 +13,7 @@ #define TO_ADD_TO_IMAGE_HEIGHT 2 /* Used for alignement */ -Timer::Timer(QImage img, QWidget *parent) +Timer::Timer(QImage img, QWidget *parent) noexcept : QGraphicsView(parent) , img(img) { @@ -25,7 +25,7 @@ Timer::Timer(QImage img, QWidget *parent) } void -Timer::mousePressEvent(QMouseEvent *event) +Timer::mousePressEvent(QMouseEvent *event) noexcept { QPoint pos = event->pos(); pos.rx() += horizontalScrollBar()->value(); diff --git a/src/Timer.h b/src/Timer.h index 2d0d93bd..12aba57e 100644 --- a/src/Timer.h +++ b/src/Timer.h @@ -17,8 +17,8 @@ public: static inline constexpr QColor startColour = QColor(127, 0, 127); static inline constexpr QColor endColour = QColor(0, 127, 0); - Timer(QImage img, QWidget *parent = nullptr); - ~Timer() = default; + Timer(QImage img, QWidget *parent = nullptr) noexcept; + ~Timer() noexcept = default; private: QGraphicsPixmapItem *bg = nullptr; @@ -26,7 +26,7 @@ private: QImage img; QVector<QLine> lines; - void mousePressEvent(QMouseEvent *event); + void mousePressEvent(QMouseEvent *event) noexcept; public slots: }; diff --git a/src/TimingBar.cc b/src/TimingBar.cc index 60e83d10..71cc97a6 100644 --- a/src/TimingBar.cc +++ b/src/TimingBar.cc @@ -10,7 +10,7 @@ #include <QVBoxLayout> #include <QScrollBar> -TimingBar::TimingBar(QLine line, QColor color, QWidget *parent) +TimingBar::TimingBar(QLine line, QColor color, QWidget *parent) noexcept : QGraphicsLineItem(line) { setPen(QPen(QBrush(color), bar_width, Qt::SolidLine, Qt::FlatCap)); @@ -26,7 +26,7 @@ void TimingBar::mousePressEvent(QGraphicsSceneMouseEvent* event){ */ QVariant -TimingBar::itemChange(GraphicsItemChange change, const QVariant &value) +TimingBar::itemChange(GraphicsItemChange change, const QVariant &value) noexcept { if (change == ItemPositionChange) { return QPointF(value.toPointF().x(), 0); diff --git a/src/TimingBar.h b/src/TimingBar.h index 3db22255..709ab537 100644 --- a/src/TimingBar.h +++ b/src/TimingBar.h @@ -7,8 +7,8 @@ class TimingBar final : public QGraphicsLineItem { public: - TimingBar(QLine, QColor, QWidget *parent = nullptr); - ~TimingBar() = default; + TimingBar(QLine, QColor, QWidget *parent = nullptr) noexcept; + ~TimingBar() noexcept = default; private: static inline constexpr int bar_demi_width = 2; @@ -16,7 +16,7 @@ private: protected: //void mousePressEvent(QGraphicsSceneMouseEvent*); - QVariant itemChange(GraphicsItemChange, const QVariant &) override; + QVariant itemChange(GraphicsItemChange, const QVariant &) noexcept override; /* void hoverEnterEvent (QGraphicsSceneHoverEvent*) override; void hoverLeaveEvent (QGraphicsSceneHoverEvent*) override; -- GitLab