From 9b9543396cc8de5ea2cbbd35f5829b9876d6ac8b Mon Sep 17 00:00:00 2001
From: Elliu <elliu@hashi.re>
Date: Sun, 24 Jul 2022 18:56:41 +0200
Subject: [PATCH] TimingLine: only send update information to AssLinesModel
No need to send content change as AssLinesModel retrieves it from the
LinePtr
---
src/UI/DocumentViews/AssLinesModel.cc | 4 ++--
src/UI/DocumentViews/AssLinesModel.hh | 2 +-
src/UI/DocumentViews/AudioVisualizer/TimingLine.cc | 4 +---
src/UI/DocumentViews/AudioVisualizer/TimingLine.hh | 2 +-
4 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/UI/DocumentViews/AssLinesModel.cc b/src/UI/DocumentViews/AssLinesModel.cc
index 01d6c091..f7641ccf 100644
--- a/src/UI/DocumentViews/AssLinesModel.cc
+++ b/src/UI/DocumentViews/AssLinesModel.cc
@@ -156,7 +156,7 @@ AssLinesModel::flags(const QModelIndex &index) const noexcept
}
void
-AssLinesModel::updateLine(int lineIndex, Ass::LinePtr line)
+AssLinesModel::updateLine(int lineIndex)
{
- setData(index(lineIndex, 0), QVariant::fromValue(line), Qt::DisplayRole);
+ emit dataChanged(index(lineIndex, 0), index(lineIndex, 0));
}
diff --git a/src/UI/DocumentViews/AssLinesModel.hh b/src/UI/DocumentViews/AssLinesModel.hh
index 61feec30..98ec19d1 100644
--- a/src/UI/DocumentViews/AssLinesModel.hh
+++ b/src/UI/DocumentViews/AssLinesModel.hh
@@ -57,6 +57,6 @@ private:
const QVector<Ass::LinePtr> &lineRealData;
public slots:
- void updateLine(int, Ass::LinePtr);
+ void updateLine(int);
};
}
diff --git a/src/UI/DocumentViews/AudioVisualizer/TimingLine.cc b/src/UI/DocumentViews/AudioVisualizer/TimingLine.cc
index 2b41a8dc..a51875c8 100644
--- a/src/UI/DocumentViews/AudioVisualizer/TimingLine.cc
+++ b/src/UI/DocumentViews/AudioVisualizer/TimingLine.cc
@@ -164,9 +164,7 @@ TimingLine::requestMove(int sepIndex, qreal x)
line.setContent(syls);
- if (given) {
- emit lineChanged(lineIndex, std::make_shared<Ass::Line>(line));
- }
+ emit lineChanged(lineIndex);
return given;
}
diff --git a/src/UI/DocumentViews/AudioVisualizer/TimingLine.hh b/src/UI/DocumentViews/AudioVisualizer/TimingLine.hh
index 3d438f3c..261d37a7 100644
--- a/src/UI/DocumentViews/AudioVisualizer/TimingLine.hh
+++ b/src/UI/DocumentViews/AudioVisualizer/TimingLine.hh
@@ -28,7 +28,7 @@ public:
qreal requestMove(int, qreal);
signals:
- void lineChanged(int, Ass::LinePtr);
+ void lineChanged(int);
public slots:
void timingSeparatorHasChanged(int, qreal);
--
GitLab