From 6372f711cbb0568f87e62c6ce7c1d0106dfadf4e Mon Sep 17 00:00:00 2001
From: Elliu <goyard.louis@gmail.com>
Date: Sat, 26 Jun 2021 13:12:47 +0200
Subject: [PATCH] Fix build warnings
Put clang and CXX specific flags only in those cases
---
CMakeLists.txt | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ec478fde..24a57006 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -71,13 +71,23 @@ target_link_libraries(Vivy PRIVATE ${AVFORMAT_LIBRARY})
target_include_directories(Vivy PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/inc)
target_compile_options(Vivy PRIVATE
- -Wall -Wextra -Wshadow -Wnon-virtual-dtor -pedantic
- -Wno-unused-private-field # Skip the unused private fields for now
- -Wcast-align -Woverloaded-virtual -Wconversion -Wsign-conversion
+ -Wall -Wextra -Wshadow -pedantic
+ -Wcast-align -Wconversion -Wsign-conversion
-Wmisleading-indentation -Wnull-dereference -Wdouble-promotion
-Wformat=2
+ $<$<COMPILE_LANGUAGE:CXX>:
+ -Woverloaded-virtual
+ -Wnon-virtual-dtor
+ >
)
+if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang")
+ target_compile_options(Vivy PRIVATE
+ -Wno-unused-private-field # Skip the unused private fields for now
+ )
+elseif (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")
+endif()
+
set_target_properties(Vivy PROPERTIES
MACOSX_BUNDLE_GUI_IDENTIFIER vivy.iiens.net
MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION}
--
GitLab